Remove ChatWindowController from ClientConnectionHandler

Make ChatWindowController listen for message changes

fixed Issue #23

client/src/main/java/ch/zhaw/pm2/multichat/client/ChatWindowController.java

@@ -6,7 +6,6 @@ import ch.zhaw.pm2.multichat.protocol.NetworkHandler;
 import javafx.application.Platform;
 import javafx.beans.value.ChangeListener;
 import javafx.beans.value.ObservableValue;
-import javafx.collections.ListChangeListener;
 import javafx.event.EventHandler;
 import javafx.fxml.FXML;
 import javafx.scene.control.Button;
@@ -42,14 +41,11 @@ public class ChatWindowController {
     public void initialize() {
         serverAddressField.setText(NetworkHandler.DEFAULT_ADDRESS.getCanonicalHostName());
         serverPortField.setText(String.valueOf(NetworkHandler.DEFAULT_PORT));
-        this.messages = new ClientMessageList();
+    }
 
-        messages.getChangedProperty().addListener(new ChangeListener<Boolean>() {
-            @Override
-            public void changed(ObservableValue<? extends Boolean> observable, Boolean oldValue, Boolean newValue) {
-                setMessageField(messages.getMessages());
-            }
-        });
+    public void setMessages(ClientMessageList messages) {
+        this.messages = messages;
+        messageListener();
     }
 
     private void applicationClose() {
@@ -58,7 +54,7 @@ public class ChatWindowController {
 
     @FXML
     private void toggleConnection () {
-        if (connectionHandler == null || connectionHandler.getStateObjectProperty().get() != CONNECTED) {
+        if (connectionHandler == null || connectionHandler.getStateProperty().get() != CONNECTED) {
             connect();
         } else {
             disconnect();
@@ -71,19 +67,19 @@ public class ChatWindowController {
             startConnectionHandler();
             connectionHandler.connect();
         } catch(ChatProtocolException | IOException e) {
-            messages.addMessage(null,null, e.getMessage(), Message.MessageType.ERROR);
+            addError(e.getMessage());
         }
     }
 
     private void disconnect() {
         if (connectionHandler == null) {
-            messages.addMessage(null,null,"No connection handler", Message.MessageType.ERROR);
+            addError("No connection handler");
             return;
         }
         try {
             connectionHandler.disconnect();
         } catch (ChatProtocolException e) {
-            messages.addMessage(null,null, e.getMessage(), Message.MessageType.ERROR);
+            addError(e.getMessage());
         }
     }
 
@@ -92,32 +88,33 @@ public class ChatWindowController {
         String messageString = messageField.getText().strip();
         try {
             if (connectionHandler == null) {
-                messages.addMessage(null,null,"No connection handler", Message.MessageType.ERROR);
+                addError("No connection handler");
             } else if (!connectionHandler.message(messageString)) {
-                messages.addMessage(null,null,"Not a valid message format.", Message.MessageType.ERROR);
+                addError("Not a valid message format.");
             } else {
                 messageField.clear();
             }
         } catch (ChatProtocolException e) {
-            messages.addMessage(null,null, e.getMessage(), Message.MessageType.ERROR);
+            addError(e.getMessage());
         }
     }
 
-    //TODO: TEST
     @FXML
     private void applyFilter( ) {
-        messages.getFilteredMessages(filterValue.getText().strip());
+    	this.redrawMessageList();
     }
 
     private void startConnectionHandler() throws IOException {
         String userName = userNameField.getText();
         String serverAddress = serverAddressField.getText();
         int serverPort = Integer.parseInt(serverPortField.getText());
-        connectionHandler = new ClientConnectionHandler(messages,serverAddress,serverPort,userName);
+        connectionHandler = new ClientConnectionHandler(
+            NetworkHandler.openConnection(serverAddress, serverPort), userName,
+            messages);
         new Thread(connectionHandler).start();
 
-        //register changelistener
-        startChangeListener();
+        //register Listener
+        startListener();
 
         // register window close handler
         rootPane.getScene().getWindow().addEventHandler(WindowEvent.WINDOW_CLOSE_REQUEST, windowCloseHandler);
@@ -145,49 +142,6 @@ public class ChatWindowController {
         }
     }
 
-    private void startChangeListener() {
-        //Listener for State
-        connectionHandler.getStateObjectProperty().addListener(new ChangeListener<State>() {
-            @Override
-            public void changed(ObservableValue<? extends State> observable, State oldValue, State newValue) {
-                stateChanged(newValue);
-            }
-        });
-
-        //Listener for Username
-        connectionHandler.getUserNameProperty().addListener(new ChangeListener<String>() {
-            @Override
-            public void changed(ObservableValue<? extends String> observable, String oldValue, String newValue) {
-                setUserName(newValue);
-            }
-        });
-
-        //Listener for Address
-        connectionHandler.getServerAddressProperty().addListener(new ChangeListener<String>() {
-            @Override
-            public void changed(ObservableValue<? extends String> observable, String oldValue, String newValue) {
-                setServerAddress(newValue);
-            }
-        });
-
-        //Listener for Port
-        connectionHandler.getServerPortProperty().addListener(new ChangeListener<Number>() {
-            @Override
-            public void changed(ObservableValue<? extends Number> observable, Number oldValue, Number newValue) {
-                setServerPort(newValue.intValue());
-            }
-        });
-    }
-
-    public void setMessageField(String message) {
-        Platform.runLater(new Runnable() {
-            @Override
-            public void run() {
-                messageField.setText(message);
-            }
-        });
-    }
-
     public void setUserName(String userName) {
         Platform.runLater(new Runnable() {
             @Override
@@ -215,7 +169,10 @@ public class ChatWindowController {
         });
     }
 
-    //TODO: MAKE ChangeListener
+    public void addError(String message) {
+        messages.addMessage(new Message(Message.MessageType.ERROR, null, null, message));
+    }
+
     private void redrawMessageList() {
         this.messageArea.clear();
         Platform.runLater(() -> this.messageArea.setText(messages.getFilteredMessages(filterValue.getText().strip())));
@@ -228,4 +185,43 @@ public class ChatWindowController {
 
     }
 
+    public void startListener() {
+        connectionHandler.getStateProperty().addListener(new ChangeListener<State>() {
+            @Override
+            public void changed(ObservableValue<? extends State> observable, State oldValue, State newValue) {
+                stateChanged(newValue);
+            }
+        });
+
+        connectionHandler.getUserNameProperty().addListener(new ChangeListener<String>() {
+            @Override
+            public void changed(ObservableValue<? extends String> observable, String oldValue, String newValue) {
+                setUserName(newValue);
+            }
+        });
+
+        connectionHandler.getServerAddressProperty().addListener(new ChangeListener<String>() {
+            @Override
+            public void changed(ObservableValue<? extends String> observable, String oldValue, String newValue) {
+                setServerAddress(newValue);
+            }
+        });
+
+        connectionHandler.getServerPortProperty().addListener(new ChangeListener<Number>() {
+            @Override
+            public void changed(ObservableValue<? extends Number> observable, Number oldValue, Number newValue) {
+                setServerPort(newValue.intValue());
+            }
+        });
+    }
+
+    private void messageListener() {
+        messages.getChangedProperty().addListener(new ChangeListener<Boolean>() {
+            @Override
+            public void changed(ObservableValue<? extends Boolean> observable, Boolean oldValue, Boolean newValue) {
+                redrawMessageList();
+            }
+        });
+    }
+
 }

client/src/main/java/ch/zhaw/pm2/multichat/client/ClientConnectionHandler.java

@@ -2,7 +2,6 @@ package ch.zhaw.pm2.multichat.client;
 
 import ch.zhaw.pm2.multichat.protocol.ChatProtocolException;
 import ch.zhaw.pm2.multichat.protocol.NetworkHandler;
-import javafx.beans.property.ObjectProperty;
 import javafx.beans.property.SimpleIntegerProperty;
 import javafx.beans.property.SimpleObjectProperty;
 import javafx.beans.property.SimpleStringProperty;
@@ -15,10 +14,9 @@ import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 import static ch.zhaw.pm2.multichat.client.ClientConnectionHandler.State.*;
-import static ch.zhaw.pm2.multichat.client.Message.MessageType.*;
 
 public class ClientConnectionHandler implements Runnable {
-    private NetworkHandler.NetworkConnection<String> connection;
+    private final NetworkHandler.NetworkConnection<String> connection;
 
     // Data types used for the Chat Protocol
     private static final String DATA_TYPE_CONNECT = "CONNECT";
@@ -30,44 +28,42 @@ public class ClientConnectionHandler implements Runnable {
     public static final String USER_NONE = "";
     public static final String USER_ALL = "*";
 
-    private SimpleStringProperty userName;
-    private SimpleIntegerProperty serverPort;
-    private SimpleStringProperty serverAddress;
-    private ObjectProperty<State> stateObjectProperty;
-    private ClientMessageList messageList;
     private final Pattern messagePattern = Pattern.compile( "^(?:@(\\w*))?\\s*(.*)$" );
 
+    private SimpleStringProperty userName;
+    private SimpleObjectProperty<State> state;
+    private ClientMessageList messages;
+    private SimpleStringProperty serverAddress;
+    private SimpleIntegerProperty serverPort;
+
     enum State {
         NEW, CONFIRM_CONNECT, CONNECTED, CONFIRM_DISCONNECT, DISCONNECTED;
     }
 
-    public ClientConnectionHandler(ClientMessageList messageList,String serverAddress,int serverPort,String userName) throws IOException {
-        this.stateObjectProperty = new SimpleObjectProperty<>(NEW);
+    public ClientConnectionHandler(NetworkHandler.NetworkConnection<String> connection,
+                                   String userName,
+                                   ClientMessageList messages)  {
+        this.connection = connection;
         this.userName = new SimpleStringProperty((userName == null || userName.isBlank())? USER_NONE : userName);
-        this.serverPort = new SimpleIntegerProperty();
-        this.serverAddress = new SimpleStringProperty();
-        this.messageList = messageList;
-        this.connection = NetworkHandler.openConnection(serverAddress,serverPort);
+        this.messages = messages;
+        state = new SimpleObjectProperty<>(NEW);
+        serverAddress = new SimpleStringProperty();
+        serverPort = new SimpleIntegerProperty();
     }
 
-    public ObjectProperty<State> getStateObjectProperty() {
-        return stateObjectProperty;
+    public SimpleStringProperty getServerAddressProperty() { return serverAddress; }
+
+    public SimpleIntegerProperty getServerPortProperty() { return serverPort; }
+
+    public SimpleObjectProperty<State> getStateProperty() {
+        return this.state;
     }
 
-    public SimpleStringProperty getUserNameProperty() {
-        return userName;
-    }
-
-    public SimpleStringProperty getServerAddressProperty() {
-        return serverAddress;
-    }
-
-    public SimpleIntegerProperty getServerPortProperty() {
-        return serverPort;
-    }
+    public SimpleStringProperty getUserNameProperty() { return userName; }
 
     public void setState (State newState) {
-        this.stateObjectProperty.set(newState);
+        state.set(newState);
+
     }
 
     public void run () {
@@ -111,7 +107,6 @@ public class ClientConnectionHandler implements Runnable {
         System.out.println("Closed Connection Handler to Server");
     }
 
-
     private void processData(String data) {
         try {
             // parse data content
@@ -142,37 +137,37 @@ public class ClientConnectionHandler implements Runnable {
             if (type.equals(DATA_TYPE_CONNECT)) {
                 System.err.println("Illegal connect request from server");
             } else if (type.equals(DATA_TYPE_CONFIRM)) {
-                if (stateObjectProperty.get() == CONFIRM_CONNECT) {
+                if (state.get() == CONFIRM_CONNECT) {
                     this.userName.set(reciever);
-                    this.serverAddress.set(connection.getRemoteHost());
                     this.serverPort.set(connection.getRemotePort());
-                    messageList.addMessage(sender,reciever,payload,INFO);
+                    this.serverAddress.set(connection.getRemoteHost());
+                    messages.addMessage(new Message(Message.MessageType.INFO,sender,reciever,payload));
                     System.out.println("CONFIRM: " + payload);
                     this.setState(CONNECTED);
-                } else if (stateObjectProperty.get() == CONFIRM_DISCONNECT) {
-                    messageList.addMessage(sender,reciever,payload,INFO);
+                } else if (state.get() == CONFIRM_DISCONNECT) {
+                    messages.addMessage(new Message(Message.MessageType.INFO,sender,reciever,payload));
                     System.out.println("CONFIRM: " + payload);
                     this.setState(DISCONNECTED);
                 } else {
                     System.err.println("Got unexpected confirm message: " + payload);
                 }
             } else if (type.equals(DATA_TYPE_DISCONNECT)) {
-                if (stateObjectProperty.get() == DISCONNECTED) {
+                if (state.get() == DISCONNECTED) {
                     System.out.println("DISCONNECT: Already in disconnected: " + payload);
                     return;
                 }
-                messageList.addMessage(sender,reciever,payload,INFO);
+                messages.addMessage(new Message(Message.MessageType.INFO,sender,reciever,payload));
                 System.out.println("DISCONNECT: " + payload);
                 this.setState(DISCONNECTED);
             } else if (type.equals(DATA_TYPE_MESSAGE)) {
-                if (stateObjectProperty.get() != CONNECTED) {
-                    System.out.println("MESSAGE: Illegal state " + stateObjectProperty.get() + " for message: " + payload);
+                if (state.get() != CONNECTED) {
+                    System.out.println("MESSAGE: Illegal state " + state + " for message: " + payload);
                     return;
                 }
-                messageList.addMessage(sender,reciever,payload,MESSAGE);
+                messages.addMessage(new Message(Message.MessageType.MESSAGE,sender,reciever,payload));
                 System.out.println("MESSAGE: From " + sender + " to " + reciever + ": "+  payload);
             } else if (type.equals(DATA_TYPE_ERROR)) {
-                messageList.addMessage(sender,reciever,payload,ERROR);
+                messages.addMessage(new Message(Message.MessageType.ERROR,sender,reciever,payload));
                 System.out.println("ERROR: " + payload);
             } else {
                 System.out.println("Unknown data type received: " + type);
@@ -205,19 +200,19 @@ public class ClientConnectionHandler implements Runnable {
     }
 
     public void connect() throws ChatProtocolException {
-        if (stateObjectProperty.get() != NEW) throw new ChatProtocolException("Illegal state for connect: " + stateObjectProperty.get());
+        if (state.get() != NEW) throw new ChatProtocolException("Illegal state for connect: " + state);
         this.sendData(userName.get(), USER_NONE, DATA_TYPE_CONNECT,null);
         this.setState(CONFIRM_CONNECT);
     }
 
     public void disconnect() throws ChatProtocolException {
-        if (stateObjectProperty.get() != NEW && stateObjectProperty.get() != CONNECTED) throw new ChatProtocolException("Illegal state for disconnect: " + stateObjectProperty.get());
+        if (state.get() != NEW && state.get() != CONNECTED) throw new ChatProtocolException("Illegal state for disconnect: " + state);
         this.sendData(userName.get(), USER_NONE, DATA_TYPE_DISCONNECT,null);
         this.setState(CONFIRM_DISCONNECT);
     }
 
     public boolean message(String messageString) throws ChatProtocolException {
-        if (stateObjectProperty.get() != CONNECTED) throw new ChatProtocolException("Illegal state for message: " + stateObjectProperty.get());
+        if (state.get() != CONNECTED) throw new ChatProtocolException("Illegal state for message: " + state);
 
         Matcher matcher = messagePattern.matcher(messageString);
         if (matcher.find()) {

client/src/main/java/ch/zhaw/pm2/multichat/client/ClientMessageList.java

@@ -1,34 +1,17 @@
 package ch.zhaw.pm2.multichat.client;
 
 import javafx.beans.property.SimpleBooleanProperty;
-import javafx.beans.property.SimpleListProperty;
-import javafx.collections.FXCollections;
-import javafx.collections.ObservableList;
 
 import java.util.ArrayList;
 import java.util.List;
 
-import static ch.zhaw.pm2.multichat.client.ClientConnectionHandler.USER_NONE;
-
 public class ClientMessageList {
-    private List<Message> messages;
-    private SimpleBooleanProperty changed;
+    private List<Message> messages = new ArrayList<>();
+    private SimpleBooleanProperty changed = new SimpleBooleanProperty(false);
 
-    public ClientMessageList() {
-        messages = new ArrayList<>();
-        changed = new SimpleBooleanProperty(true);
-    }
-
-    public SimpleBooleanProperty getChangedProperty() {
-        return changed;
-    }
-
-    public void addMessage(String sender, String receiver, String message, Message.MessageType type) {
-        if(sender == null) {
-            sender = USER_NONE;
-        }
-        messages.add(new Message(type, sender, receiver, message));
-        changed.set(!changed.get());
+    public void addMessage(Message message) {
+	    messages.add(message);
+	    changed.set(!changed.get());
     }
 
 	public String getFilteredMessages(String filter) {
@@ -48,21 +31,11 @@ public class ClientMessageList {
         return result.toString();
 	}
 
-	public String getMessages() {
-        StringBuilder result = new StringBuilder();
-        for(Message message : messages) {
-            switch (message.getType()) {
-                case MESSAGE -> result.append(String.format("[%s -> %s] %s\n", message.getSender(), message.getReceiver(), message.getText()));
-                case ERROR -> result.append(String.format("[ERROR] %s\n", message.getText()));
-                case INFO -> result.append(String.format("[INFO] %s\n", message.getText()));
-                default -> result.append(String.format("[ERROR] %s\n", "Unexpected message type: " + message.getType()));
-            }
-        }
-        return result.toString();
+    public void clear() {
+        messages = new ArrayList<>();
+        changed.set(!changed.get());
     }
 
-    public void clear() {
-        messages = new SimpleListProperty<>();
-    }
+    public SimpleBooleanProperty getChangedProperty() { return changed; }
 
 }

client/src/main/java/ch/zhaw/pm2/multichat/client/ClientUI.java

@@ -17,9 +17,11 @@ public class ClientUI extends Application {
     private void chatWindow(Stage primaryStage) {
         try {
             FXMLLoader loader = new FXMLLoader(getClass().getResource("ChatWindow.fxml"));
-
             Pane rootPane = loader.load();
 
+            ChatWindowController chatWindowController = loader.getController();
+            chatWindowController.setMessages(clientMessageList);
+
             // fill in scene and stage setup
             Scene scene = new Scene(rootPane);
             //scene.getStylesheets().add(getClass().getResource("application.css").toExternalForm());

server/src/main/java/ch/zhaw/pm2/multichat/server/ServerConnectionHandler.java

@@ -55,7 +55,7 @@ public class ServerConnectionHandler implements Runnable{
     }
 
     public void startReceiving() {
-        System.out.println("Starting Connection Handler for " + userName);
+        System.out.println("Starting Connection Handler for new User");
         try {
             System.out.println("Start receiving data...");
             while (connection.isAvailable()) {