src/main/java/ch/zhaw/gartenverwaltung/MainFXMLController.java

@@ -10,16 +10,10 @@ import javafx.scene.layout.AnchorPane;
 
 import java.io.IOException;
 import java.net.URL;
-import java.util.HashMap;
-import java.util.Map;
 import java.util.Objects;
 import java.util.ResourceBundle;
 
 public class MainFXMLController implements Initializable {
-    /**
-     * Caching the panes
-     */
-    private final Map<String, Node> panes = new HashMap<>();
 
     @FXML
     private Button home_button;
@@ -69,17 +63,12 @@ public class MainFXMLController implements Initializable {
      */
     public void loadPane(String fxmlFile) throws IOException {
         //ToDo HGrow and VGrow of new node
-        Node node = panes.get(fxmlFile);
-        System.out.println(node);
-        if (node == null) {
-            FXMLLoader loader = new FXMLLoader(Objects.requireNonNull(HelloApplication.class.getResource(fxmlFile)));
-            node = loader.load();
-            panes.put(fxmlFile, node);
-
-            if(fxmlFile.equals("MyPlants.fxml")) {
-                MyPlantsController myPlantsController = loader.getController();
-                myPlantsController.getMainController(this);
-            }
+        Node node;
+        FXMLLoader loader = new FXMLLoader(Objects.requireNonNull(HelloApplication.class.getResource(fxmlFile)));
+        node = (Node)loader.load();
+        if(fxmlFile.equals("MyPlants.fxml")) {
+            MyPlantsController myPlantsController = loader.getController();
+            myPlantsController.getMainController(this);
         }
         mainPane.getChildren().setAll(node);
     }

src/main/java/ch/zhaw/gartenverwaltung/PlantsController.java

@@ -4,23 +4,19 @@ import ch.zhaw.gartenverwaltung.io.HardinessZoneNotSetException;
 import ch.zhaw.gartenverwaltung.plantList.PlantListModel;
 import ch.zhaw.gartenverwaltung.types.HardinessZone;
 import ch.zhaw.gartenverwaltung.types.Plant;
-import javafx.application.Platform;
-import javafx.beans.property.ListProperty;
-import javafx.beans.property.SimpleListProperty;
 import javafx.beans.value.ChangeListener;
 import javafx.beans.value.ObservableValue;
-import javafx.collections.FXCollections;
 import javafx.event.ActionEvent;
 import javafx.fxml.FXML;
 import javafx.fxml.Initializable;
-import javafx.geometry.Bounds;
 import javafx.scene.control.*;
 import javafx.scene.image.ImageView;
-import javafx.scene.input.KeyEvent;
+import javafx.scene.input.InputMethodEvent;
 import javafx.scene.layout.VBox;
 
 import java.io.IOException;
 import java.net.URL;
+import java.util.LinkedList;
 import java.util.List;
 import java.util.ResourceBundle;
 
@@ -29,9 +25,6 @@ public class PlantsController implements Initializable {
     private Plant selectedPlant = null;
     private final HardinessZone DEFAULT_HARDINESS_ZONE = HardinessZone.ZONE_8A;
 
-    // TODO: move to model
-    private final ListProperty<Plant> plantListProperty = new SimpleListProperty<>(FXCollections.observableArrayList());
-
     @FXML
     private CheckBox autum_filter;
 
@@ -92,7 +85,7 @@ public class PlantsController implements Initializable {
     }
 
     @FXML
-    void searchForPlant(KeyEvent event) {
+    void searchForPlant(InputMethodEvent event) {
         viewFilteredListBySearch(search_plants.getText());
     }
 
@@ -101,20 +94,13 @@ public class PlantsController implements Initializable {
      */
     @Override
     public void initialize(URL url, ResourceBundle resourceBundle) {
-        setListCellFactory();
+        List<Plant> plantList = new LinkedList<>();
         try {
-            plantListProperty.addAll(plantListModel.getPlantList(DEFAULT_HARDINESS_ZONE));
+            plantList = plantListModel.getPlantList(DEFAULT_HARDINESS_ZONE);
         } catch (HardinessZoneNotSetException | IOException e) {
             e.printStackTrace();
         }
-
-        list_plants.itemsProperty().bind(plantListProperty);
-        list_plants.getSelectionModel().selectedItemProperty()
-                .addListener((observable, oldPlant, newPlant) -> {
-                    if (newPlant != null) {
-                        img_plant.setImage(newPlant.image());
-                    }
-                });
+        fillListViewWithData(plantList);
 
         description_plant.setText("");
         saveToMyPlant_button.setDisable(true);
@@ -123,12 +109,16 @@ public class PlantsController implements Initializable {
         lookForSelectedListEntry();
     }
 
-    private void centerImage() {
-
-        //img_plant.setX(0.3);
-        //img_plant.setX(-100);
-    }
-    private void setListCellFactory() {
+    /**
+     * update the ListView according to the plant list provided
+     * Entry in ListView is plant name
+     * @param list plantList which fill the ListView
+     */
+    private void fillListViewWithData(List<Plant> list) {
+        clearListView();
+        for (Plant plant : list) {
+            list_plants.getItems().add(plant);
+        }
         list_plants.setCellFactory(param -> new ListCell<Plant>() {
             @Override
             protected void updateItem(Plant plant, boolean empty) {
@@ -143,19 +133,6 @@ public class PlantsController implements Initializable {
         });
     }
 
-    /**
-     * update the ListView according to the plant list provided
-     * Entry in ListView is plant name
-     * @param list plantList which fill the ListView
-     */
-    private void fillListViewWithData(List<Plant> list) {
-        clearListView();
-        for (Plant plant : list) {
-            list_plants.getItems().add(plant);
-        }
-
-    }
-
     private void viewFilteredListByFilters() {
         boolean springValue = spring_filter.isSelected();
         boolean sommerValue = sommer_filter.isSelected();
@@ -168,14 +145,8 @@ public class PlantsController implements Initializable {
 
     private void viewFilteredListBySearch(String query) {
         //ToDo getFilteredPlantList with (plantListModel.getFilteredPlantList(DEFAULT_HARDINESS_ZONE, <predicate>))
-        try {
-            List<Plant> filteredPlants = plantListModel.getFilteredPlantListByString(DEFAULT_HARDINESS_ZONE, query);
-            clearListView();
-            plantListProperty.addAll(filteredPlants);
-
-        } catch (HardinessZoneNotSetException | IOException e) {
-            e.printStackTrace();
-        }
+        //List<Plant> plantList = new LinkedList<>();
+        //fillListViewWithData(plantList);
     }
 
     private void createFilterHardinessZone() {
@@ -210,6 +181,6 @@ public class PlantsController implements Initializable {
      * clears the ListView of entries
      */
     private void clearListView() {
-        plantListProperty.clear();
+        list_plants.getItems().clear();
     }
 }

src/main/java/ch/zhaw/gartenverwaltung/io/JsonTaskDatabase.java

@@ -5,11 +5,9 @@ import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 import com.fasterxml.jackson.datatype.jsr310.deser.LocalDateDeserializer;
-import com.fasterxml.jackson.datatype.jsr310.ser.LocalDateSerializer;
 
 import java.io.File;
 import java.io.IOException;
-import java.net.URISyntaxException;
 import java.net.URL;
 import java.time.LocalDate;
 import java.time.format.DateTimeFormatter;
@@ -26,7 +24,6 @@ import java.util.Map;
 public class JsonTaskDatabase implements TaskDatabase{
     IdProvider idProvider;
     private final URL dataSource = getClass().getResource("taskdb.json");
-    private final static String INVALID_DATASOURCE_MSG = "Invalid datasource specified!";
 
     private Map<Long, Task> taskMap = Collections.emptyMap();
 
@@ -37,10 +34,7 @@ public class JsonTaskDatabase implements TaskDatabase{
     static {
         DateTimeFormatter dateFormat = DateTimeFormatter.ofPattern("yyyy-MM-dd");
         LocalDateDeserializer dateDeserializer = new LocalDateDeserializer(dateFormat);
-        LocalDateSerializer dateSerializer = new LocalDateSerializer(dateFormat);
-
         timeModule.addDeserializer(LocalDate.class, dateDeserializer);
-        timeModule.addSerializer(LocalDate.class, dateSerializer);
     }
 
     /**
@@ -101,16 +95,12 @@ public class JsonTaskDatabase implements TaskDatabase{
      * @throws IOException If the database cannot be accessed
      */
     private void writeTaskListToFile() throws IOException {
-        if(dataSource != null) {
-            try {
-                new ObjectMapper()
-                        .registerModule(timeModule)
-                        .registerModule(new Jdk8Module())
-                        .writeValue(new File(dataSource.toURI()), taskMap.values());
+        ObjectMapper mapper = new ObjectMapper();
+        mapper.registerModule(timeModule)
+                .registerModule(new Jdk8Module());
 
-            } catch (URISyntaxException e) {
-                throw new IOException(INVALID_DATASOURCE_MSG, e);
-            }
+        if(dataSource != null) {
+            mapper.writeValue(new File(dataSource.getFile()), taskMap);
         }
     }
 
@@ -122,8 +112,7 @@ public class JsonTaskDatabase implements TaskDatabase{
     private void loadTaskListFromFile() throws IOException {
         if (dataSource != null) {
             ObjectMapper mapper = new ObjectMapper();
-            mapper.registerModule(timeModule)
-                    .registerModule(new Jdk8Module());
+            mapper.registerModule(timeModule);
 
             List<Task> result;
             result = mapper.readerForListOf(Task.class).readValue(dataSource);

src/main/java/ch/zhaw/gartenverwaltung/json/PlantImageDeserializer.java

@@ -6,11 +6,9 @@ import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonDeserializer;
 import javafx.scene.image.Image;
 
-import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.net.URISyntaxException;
 import java.net.URL;
 
 public class PlantImageDeserializer extends JsonDeserializer<Image> {
@@ -20,9 +18,9 @@ public class PlantImageDeserializer extends JsonDeserializer<Image> {
         Image result = null;
         URL imageUrl = PlantDatabase.class.getResource(String.format("images/%s", parser.getText()));
         if (imageUrl != null) {
-            try (InputStream is = new FileInputStream(new File(imageUrl.toURI()))) {
+            try (InputStream is = new FileInputStream(imageUrl.getFile())) {
                 result = new Image(is);
-            } catch (IllegalArgumentException | URISyntaxException e) {
+            } catch (IllegalArgumentException e) {
                 // TODO: Log
                 e.printStackTrace();
                 System.err.printf("Cannot find Image \"%s\"\n", imageUrl.getFile());

src/main/java/ch/zhaw/gartenverwaltung/plantList/PlantListModel.java

@@ -33,12 +33,12 @@ public class PlantListModel {
         setDefaultZone();
     }
 
-    public PlantListModel(PlantDatabase plantDatabase) {
+    public PlantListModel(PlantDatabase plantDatabase){
         this.plantDatabase = plantDatabase;
         setDefaultZone();
     }
 
-    private void setDefaultZone() {
+    private void setDefaultZone(){
         currentZone = HardinessZone.ZONE_8A; // TODO: get Default Zone from Config
     }
 
@@ -52,7 +52,6 @@ public class PlantListModel {
 
     /**
      * Method to get actual Plant List in alphabetic Order
-     *
      * @return actual Plant List in alphabetic Order
      */
     public List<Plant> getPlantList(HardinessZone zone) throws HardinessZoneNotSetException, IOException {
@@ -63,11 +62,10 @@ public class PlantListModel {
 
     /**
      * Method to get the actual Plant list in custom Order
-     *
-     * @param zone       selected hardiness zone
+     * @param zone selected hardiness zone
      * @param comparator comparator to sort the list
      * @return sorted list with plants in the given hardiness zone
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
      */
     public List<Plant> getSortedPlantList(HardinessZone zone, Comparator<Plant> comparator) throws HardinessZoneNotSetException, IOException {
@@ -77,11 +75,10 @@ public class PlantListModel {
 
     /**
      * Method to get Filtered plant list
-     *
      * @param predicate predicate to filter the list
-     * @param zone      selected hardiness zone
+     * @param zone selected hardiness zone
      * @return filterd list with plants in the hardinness zone
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
      */
     public List<Plant> getFilteredPlantList(HardinessZone zone, Predicate<Plant> predicate) throws HardinessZoneNotSetException, IOException {
@@ -91,11 +88,10 @@ public class PlantListModel {
 
     /**
      * Method to get Filtered plant list by id by exact match
-     *
      * @param zone selected hardiness zone
-     * @param id   id of plant
+     * @param id id of plant
      * @return if id doesn't exist: empty List, else list with 1 plant entry.
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
      */
     public List<Plant> getFilteredPlantListById(HardinessZone zone, Long id) throws HardinessZoneNotSetException, IOException {
@@ -106,63 +102,62 @@ public class PlantListModel {
     }
 
     /**
-     * @param zone         selected hardiness zone
+     *
+     * @param zone selected hardiness zone
      * @param searchString the string to search plant List, set '#' as first char the search by id.
      * @return List of plants found in Plant List which contain the search String in the name or description
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      */
     public List<Plant> getFilteredPlantListByString(HardinessZone zone, String searchString) throws HardinessZoneNotSetException, IOException {
-        if (searchString.length() == 0) {
+        if(searchString.length() == 0){
             return getPlantList(zone);
-        } else if (searchString.charAt(0) == '#') {
+        } else if(searchString.charAt(0) == '#') {
             try {
                 return getFilteredPlantListById(zone, Long.parseLong(searchString.substring(1)));
             } catch (NumberFormatException e) {
                 return new ArrayList<>();
             }
         } else {
-            String caseInsensitiveSearchString = searchString.toLowerCase();
-            return getFilteredPlantList(zone, plant ->
-                            plant.name().toLowerCase().contains(caseInsensitiveSearchString) ||
-                                    plant.description().toLowerCase().contains(caseInsensitiveSearchString)
-            );
+            return getFilteredPlantList(zone, plant -> plant.name().contains(searchString) || plant.description().contains(searchString));
         }
     }
 
-
     /**
+     *
      * @param type GrowPhaseType to filter
      * @param zone selected hardiness zone
      * @param from the earliest date to for the filter
-     * @param to   the lastest date for the filter
+     * @param to the lastest date for the filter
      * @return List of Plants with selected saison
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      */
     private List<Plant> getFilteredPlantListBySaison(GrowthPhaseType type, HardinessZone zone, MonthDay from, MonthDay to) throws HardinessZoneNotSetException, IOException {
         return getFilteredPlantList(zone, plant -> plant.lifecycle().stream().anyMatch(growthPhase -> growthPhase.startDate().compareTo(from) >= 0 && (growthPhase.startDate().compareTo(to) <= 0) && growthPhase.type() == type));
     }
 
     /**
+     *
      * @param zone selected hardiness zone
      * @param from the earliest date to for the filter
-     * @param to   the lastest date for the filter
+     * @param to the lastest date for the filter
      * @return List of Plants with selected saison
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      */
     public List<Plant> getFilteredPlantListByPlantingSaison(HardinessZone zone, MonthDay from, MonthDay to) throws HardinessZoneNotSetException, IOException {
         return getFilteredPlantListBySaison(GrowthPhaseType.PLANT, zone, from, to);
     }
 
     /**
+     *
      * @param zone selected hardiness zone
      * @param from the earliest date to for the filter
-     * @param to   the lastest date for the filter
+     * @param to the lastest date for the filter
      * @return List of Plants with selected saison
      * @throws HardinessZoneNotSetException If no {@link HardinessZone} was specified
-     * @throws IOException                  If the database cannot be accessed
+     * @throws IOException If the database cannot be accessed
      */
     public List<Plant> getFilteredPlantListByHarvestSaison(HardinessZone zone, MonthDay from, MonthDay to) throws HardinessZoneNotSetException, IOException {
         return getFilteredPlantListBySaison(GrowthPhaseType.HARVEST, zone, from, to);

src/main/resources/ch/zhaw/gartenverwaltung/Plants.fxml

@@ -30,7 +30,7 @@
                               <Font name="System Bold" size="30.0" />
                            </font>
                         </Label>
-                        <TextField fx:id="search_plants" onKeyTyped="#searchForPlant" promptText="Search for Plant Name" />
+                        <TextField fx:id="search_plants" onInputMethodTextChanged="#searchForPlant" promptText="Search for Plant Name" />
                         <HBox alignment="CENTER_LEFT" prefHeight="480.0" prefWidth="881.0" VBox.vgrow="ALWAYS">
                            <children>
                               <ListView fx:id="list_plants" maxWidth="1.7976931348623157E308" prefHeight="497.0" prefWidth="580.0" HBox.hgrow="ALWAYS" />

src/main/resources/ch/zhaw/gartenverwaltung/io/taskdb.json

@@ -1,50 +1,50 @@
 [
   {
-    "id": 1,
-    "name": "sow plant",
-    "description": "Plant the seeds, crops in de bed.",
-    "startDate": "2022-05-01",
-    "endDate": "2022-05-01",
-    "interval": 0
+  "id" : 1,
+  "name" : "sow plant",
+  "description": "Plant the seeds, crops in de bed.",
+  "startDate" : "2022-05-01",
+  "endDate" : "2022-05-01",
+  "interval" : 0
   },
   {
-    "id": 2,
-    "name": "water plant",
+    "id" : 2,
+    "name" : "water plant",
     "description": "water the plant, so that the soil is wet around the plant.",
-    "startDate": "2022-05-01",
-    "endDate": "2022-09-01",
-    "interval": 2
+    "startDate" : "2022-05-01",
+    "endDate" : "2022-09-01",
+    "interval" : 2
   },
   {
-    "id": 3,
-    "name": "fertilize plant",
+    "id" : 3,
+    "name" : "fertilize plant",
     "description": "The fertilizer has to be mixed with water. Then fertilize the plants soil with the mixture",
-    "startDate": "2022-06-01",
-    "endDate": "2022-08-01",
-    "interval": 28
+    "startDate" : "2022-06-01",
+    "endDate" : "2022-08-01",
+    "interval" : 28
   },
   {
-    "id": 4,
-    "name": "covering plant",
+    "id" : 4,
+    "name" : "covering plant",
     "description": "Take a big enough coverage for the plants. Cover the whole plant with a bit space between the plant and the coverage",
-    "startDate": "2022-07-01",
-    "endDate": "2022-07-01",
-    "interval": 0
+    "startDate" : "2022-07-01",
+    "endDate" : "2022-07-01",
+    "interval" : 0
   },
   {
-    "id": 5,
-    "name": "look after plant",
+    "id" : 5,
+    "name" : "look after plant",
     "description": "Look for pest or illness at the leaves of the plant. Check the soil around the plant, if the roots are enough covered with soil",
-    "startDate": "2022-05-01",
-    "endDate": "2022-09-01",
-    "interval": 5
+    "startDate" : "2022-05-01",
+    "endDate" : "2022-09-01",
+    "interval" : 5
   },
   {
-    "id": 6,
-    "name": "harvest plant",
+    "id" : 6,
+    "name" : "harvest plant",
     "description": "Pull the ripe vegetables out from the soil. Clean them with clear, fresh water. ",
-    "startDate": "2022-09-01",
-    "endDate": "2022-09-01",
-    "interval": 0
+    "startDate" : "2022-09-01",
+    "endDate" : "2022-09-01",
+    "interval" : 0
   }
 ]

src/test/java/ch/zhaw/gartenverwaltung/io/JsonTaskDatabaseTest.java

@@ -6,80 +6,32 @@ import org.junit.jupiter.api.*;
 import java.io.IOException;
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
-import java.time.LocalDate;
-import java.time.format.DateTimeFormatter;
 import java.util.Date;
 import java.util.List;
-import java.util.Optional;
-
 public class JsonTaskDatabaseTest {
 
     TaskDatabase testDatabase;
-    DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy");
+    SimpleDateFormat formatter = new SimpleDateFormat("dd.MM.yyyy");
     @BeforeEach
     void connectToDb() {
-        testDatabase = new JsonTaskDatabase();
+        // testDatabase = new JsonTaskDatabase();
     }
 
 
     @Test
     @DisplayName("Check if results are retrieved completely")
     void getTasks(){
-
+        /*
         List<Task> taskList=null;
         try {
-            taskList = testDatabase.getTaskList(LocalDate.parse("30.04.2022",formatter),
-                    LocalDate.parse("31.05.2022",formatter));
+            taskList = testDatabase.getTaskList(formatter.parse("01.05.2022"), formatter.parse("01.08.2022"));
         } catch (IOException e) {
             throw new RuntimeException(e);
+        } catch (ParseException e) {
+            throw new RuntimeException(e);
         }
 
-        Assertions.assertEquals(3,taskList.size());
-
+        Assertions.assertTrue(taskList.size()>0);
+        */
     }
-
-    //@Disabled("disabled until idProvider works")
-    @Test
-    @DisplayName("Add task.")
-    void addTask(){
-        Task task = new Task("Testtask","This is a test Task.",LocalDate.parse("01.05.2022",formatter));
-        try {
-            testDatabase.saveTask(task);
-            List<Task> taskList=null;
-            try {
-                taskList = testDatabase.getTaskList(LocalDate.parse("30.04.2022",formatter),
-                        LocalDate.parse("31.05.2022",formatter));
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            }
-
-            Assertions.assertEquals(4,taskList.size());
-
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
-    }
-
-    @Test
-    @DisplayName("Remove task.")
-    void removeTask(){
-    Task task = new Task("Dummy","Dummy",LocalDate.parse("31.05.2022",formatter)).withId(2);
-        try {
-            testDatabase.removeTask(task);
-            List<Task> taskList=null;
-            try {
-                taskList = testDatabase.getTaskList(LocalDate.parse("30.04.2022",formatter),
-                        LocalDate.parse("31.05.2022",formatter));
-            } catch (IOException e) {
-                throw new RuntimeException(e);
-            }
-
-            Assertions.assertEquals(2,taskList.size());
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
-
-    }
-
-
 }