From bf32d978bce28569104b238f5a70877f4f1a3e4a Mon Sep 17 00:00:00 2001
From: Speedy Gonzalez <amadoste@students.zhaw.ch>
Date: Tue, 7 Dec 2021 15:27:56 +0100
Subject: [PATCH] checked some warnings in class SiedlerGame.

---
 src/ch/zhaw/catan/SiedlerGame.java | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/ch/zhaw/catan/SiedlerGame.java b/src/ch/zhaw/catan/SiedlerGame.java
index fa64686..b14895a 100644
--- a/src/ch/zhaw/catan/SiedlerGame.java
+++ b/src/ch/zhaw/catan/SiedlerGame.java
@@ -19,10 +19,10 @@ public class SiedlerGame {
     static final int FOUR_TO_ONE_TRADE_OFFER = 4;
     static final int FOUR_TO_ONE_TRADE_WANT = 1;
 
-    private SiedlerBoard board;
-    private ArrayList<Player> allPlayers;
-    private int winPointsForWin;
-    private Bank bank;
+    private final SiedlerBoard board;
+    private final ArrayList<Player> allPlayers;
+    private final int winPointsForWin;
+    private final Bank bank;
     private int activePlayer;
 
     /**
@@ -222,7 +222,7 @@ public class SiedlerGame {
             Map<Faction,List<Resource>> returnMap= new HashMap<>();
             List<Point> diceValueFields = board.getFieldsForDiceValue(dicethrow);
             for (Player player : allPlayers) {
-                returnMap.put(player.getFaction(), new ArrayList());
+                returnMap.put(player.getFaction(), new ArrayList<>());
                 for (Point field : diceValueFields) {
                     List<Resource> resources = board.getResourcesforFaction(field,player.getFaction());
                     for (Config.Resource resource : resources){
@@ -367,9 +367,9 @@ public class SiedlerGame {
 
 
     /**
-     * Can be used for both initial Settlement and normal Phase.
-     * @param roadStart
-     * @param roadEnd
+     * This Method is used to check if the chosen position for a road is valid or not.
+     * @param roadStart the coordinates where the road begins.
+     * @param roadEnd the coordinates where the roads ends.
      * @return
      */
     private boolean validPositionForRoad(Point roadStart, Point roadEnd){