From f0a114955898a3714090ef4c23cd0d25a8c59ea5 Mon Sep 17 00:00:00 2001
From: schrom01 <schrom01@students.zhaw.ch>
Date: Thu, 16 Feb 2023 20:14:11 +0100
Subject: [PATCH] donations.php cleanup

---
 donations/donations.php | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/donations/donations.php b/donations/donations.php
index 2df6b83..a77dbb4 100644
--- a/donations/donations.php
+++ b/donations/donations.php
@@ -1,6 +1,7 @@
 <?php
 $dolibarrURL = "https://dolibarr.romanschenk.ch/";
-function createDonation($amount, $dolibarrURL) {
+$dolibarrAPIKey = "4mQX4x4x65MlkGZ9HUD5A4oElqTn92kl";
+function createDonation($amount, $dolibarrURL, $dolibarrAPIKey) {
     $BusinesspartnerID = "220";
     $pulicNote = "Automatisch generiert von genderwatchprotocol.com";
     $ch = curl_init();
@@ -13,7 +14,7 @@ function createDonation($amount, $dolibarrURL) {
     $headers = array();
     $headers[] = 'Content-Type: application/json';
     $headers[] = 'Accept: application/json';
-    $headers[] = 'Dolapikey: 4mQX4x4x65MlkGZ9HUD5A4oElqTn92kl';
+    $headers[] = 'Dolapikey: '.$dolibarrAPIKey;
     curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
 
     $result = curl_exec($ch);
@@ -24,7 +25,7 @@ function createDonation($amount, $dolibarrURL) {
     return $result;
 }
 
-function validateDonation($donationID, $dolibarrURL) {
+function validateDonation($donationID, $dolibarrURL, $dolibarrAPIKey) {
     $ch = curl_init();
 
     curl_setopt($ch, CURLOPT_URL, $dolibarrURL."api/index.php/donations/".$donationID."/validate");
@@ -35,7 +36,7 @@ function validateDonation($donationID, $dolibarrURL) {
     $headers = array();
     $headers[] = 'Content-Type: application/json';
     $headers[] = 'Accept: application/json';
-    $headers[] = 'Dolapikey: 4mQX4x4x65MlkGZ9HUD5A4oElqTn92kl';
+    $headers[] = 'Dolapikey: '.$dolibarrAPIKey;
     curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
 
     $result = curl_exec($ch);
@@ -45,20 +46,20 @@ function validateDonation($donationID, $dolibarrURL) {
     curl_close($ch);
     return $result;
 }
-function forwardToDonationPage($amount, $dolibarrURL){
-    $donationID = createDonation($amount, $dolibarrURL);
-    validateDonation($donationID, $dolibarrURL);
+function forwardToDonationPage($amount, $dolibarrURL, $dolibarrAPIKey){
+    $donationID = createDonation($amount, $dolibarrURL, $dolibarrAPIKey);
+    validateDonation($donationID, $dolibarrURL, $dolibarrAPIKey);
     $payment_link = $dolibarrURL."public/payment/newpayment.php?source=donation&ref=".($donationID)."&securekey=NSmKzZ73HW1zWO8nAlpdq95mDt77Q32o";
     header('Location: '.$payment_link);
 }
 
 $amount = (float)($_GET["amount"]);
 if(is_numeric($amount) && $amount > 0) {
-    forwardToDonationPage($amount, $dolibarrURL);
+    forwardToDonationPage($amount, $dolibarrURL, $dolibarrAPIKey);
 } else {
     $amount = (float)($_POST["amount"]);
     if(is_numeric($amount) && $amount > 0) {
-        forwardToDonationPage($amount, $dolibarrURL);
+        forwardToDonationPage($amount, $dolibarrURL, $dolibarrAPIKey);
     } else {
         echo "invalid amount!";
     }