fixed image loading when app is packed as jar

https://stackoverflow.com/questions/2308188/getresourceasstream-vs-fileinputstream

src/main/java/ch/zhaw/gartenverwaltung/HelloController.java

@@ -1,14 +0,0 @@
-package ch.zhaw.gartenverwaltung;
-
-import javafx.fxml.FXML;
-import javafx.scene.control.Label;
-
-public class HelloController {
-    @FXML
-    private Label welcomeText;
-
-    @FXML
-    protected void onHelloButtonClick() {
-        welcomeText.setText("Welcome to JavaFX Application!");
-    }
-}

src/main/java/ch/zhaw/gartenverwaltung/PlantsController.java

@@ -233,11 +233,11 @@ public class PlantsController {
             RadioButton radioButton = new RadioButton(season.getName());
             radioButton.setToggleGroup(seasonGroup);
             radioButton.setPadding(new Insets(0, 0, 10, 0));
-            if (season.equals(Seasons.AllSEASONS)) {
+            if (season.equals(Seasons.ALLSEASONS)) {
                 radioButton.setSelected(true);
             }
             radioButton.selectedProperty().addListener((observable, oldValue, newValue) -> {
-                if (season.equals(Seasons.AllSEASONS)) {
+                if (season.equals(Seasons.ALLSEASONS)) {
                     fillPlantListWithHardinessZone();
                 } else {
                     try {

src/main/java/ch/zhaw/gartenverwaltung/bootstrap/AfterInject.java

@@ -6,7 +6,7 @@ import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
 /**
- * Annotates a method to be executed after all dependencies annotates with {@link Inject}
+ * Annotates a method to be executed after all dependencies annotated with {@link Inject}
  * have been injected.
  */
 @Retention(RetentionPolicy.RUNTIME)

src/main/java/ch/zhaw/gartenverwaltung/bootstrap/AppLoader.java

@@ -23,6 +23,10 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.Objects;
 
+/**
+ * Class responsible for bootstrapping the application wide dependencies
+ * and injecting them into JavaFX Controllers.
+ */
 public class AppLoader {
     /**
      * Caching the panes
@@ -32,17 +36,24 @@ public class AppLoader {
     /**
      * Application-wide dependencies
      */
-    private final PlantList plantList = new JsonPlantList();
+    private final Map<String, Object> dependencies = new HashMap<>();
-    private final CropList cropList = new JsonCropList();
-    private final TaskList taskList = new JsonTaskList();
-
-    private final GardenSchedule gardenSchedule = new GardenSchedule(taskList, plantList);
-    private final Garden garden = new Garden(gardenSchedule, cropList);
-
 
     public AppLoader() throws IOException {
-    }
+        PlantList plantList = new JsonPlantList();
+        CropList cropList = new JsonCropList();
+        TaskList taskList = new JsonTaskList();
+        GardenSchedule gardenSchedule = new GardenSchedule(taskList, plantList);
 
+        dependencies.put(PlantList.class.getSimpleName(), plantList);
+        dependencies.put(CropList.class.getSimpleName(), cropList);
+        dependencies.put(TaskList.class.getSimpleName(), taskList);
+
+        dependencies.put(PlantListModel.class.getSimpleName(), new PlantListModel(plantList));
+
+        dependencies.put(GardenSchedule.class.getSimpleName(), gardenSchedule);
+        dependencies.put(Garden.class.getSimpleName(), new Garden(gardenSchedule, cropList));
+        dependencies.put(AppLoader.class.getSimpleName(), this);
+    }
 
     /**
      * Loads and returns a {@link Pane} (cached).
@@ -135,26 +146,18 @@ public class AppLoader {
                 });
 
         Arrays.stream(controller.getClass().getMethods())
-                .filter(method -> method.isAnnotationPresent(AfterInject.class))
+                .filter(method -> method.isAnnotationPresent(AfterInject.class) && method.getParameterCount() == 0)
                 .forEach(afterInjectMethod -> {
-                    if (afterInjectMethod.getParameterCount() == 0) {
                     try {
                         afterInjectMethod.invoke(controller);
                     } catch (IllegalAccessException | InvocationTargetException e) {
+                        // TODO: Log
                         e.printStackTrace();
                     }
-                    }
                 });
     }
 
     private Object getAppDependency(Class<?> type) {
-        return switch (type.getSimpleName()) {
+        return dependencies.get(type.getSimpleName());
-            case "Garden" -> garden;
-            case "PlantList" -> plantList;
-            case "PlantListModel" -> new PlantListModel(plantList);
-            case "GardenSchedule" -> gardenSchedule;
-            case "AppLoader" -> this;
-            default -> null;
-        };
     }
 }

src/main/java/ch/zhaw/gartenverwaltung/bootstrap/ChangeViewEvent.java

@@ -3,11 +3,20 @@ package ch.zhaw.gartenverwaltung.bootstrap;
 import javafx.event.Event;
 import javafx.event.EventType;
 
+/**
+ * Represents an event that should lead to a view being changed.
+ */
 public class ChangeViewEvent extends Event {
     private final String view;
 
     public static final EventType<ChangeViewEvent> CHANGE_MAIN_VIEW = new EventType<>("CHANGE_MAIN_VIEW");
 
+    /**
+     * Creates an Event that should lead to the main view being changed.
+     *
+     * @param eventType The {@link EventType<ChangeViewEvent>} specifying which view should be changed.
+     * @param view The filename of the View to be changed to
+     */
     public ChangeViewEvent(EventType<? extends Event> eventType, String view) {
         super(eventType);
         this.view = view;

src/main/java/ch/zhaw/gartenverwaltung/bootstrap/Inject.java

@@ -6,7 +6,7 @@ import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
 /**
- * Annotates a Field to be injected from the application-dependencies
+ * Annotates a Field to be injected from the application-dependencies.
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.FIELD)

src/main/java/ch/zhaw/gartenverwaltung/io/CropList.java

@@ -6,6 +6,10 @@ import java.io.IOException;
 import java.util.List;
 import java.util.Optional;
 
+/**
+ * Represents a List of {@link Crop}s.
+ * The interface specifies the operations to add/update and remove entries.
+ */
 public interface CropList {
     /**
      * Yields a list of all {@link Crop}s in the database.

src/main/java/ch/zhaw/gartenverwaltung/io/IdProvider.java

@@ -1,10 +1,18 @@
 package ch.zhaw.gartenverwaltung.io;
 
+/**
+ * Provides an sequential ID starting from the given initial Value.
+ */
 public class IdProvider {
     private long currentId;
     public IdProvider(long initialValue) {
         currentId = initialValue;
     }
+
+    /**
+     * Yields the next ID in the sequence.
+     * @return The next ID
+     */
     public long incrementAndGet() {
         return ++currentId;
     }

src/main/java/ch/zhaw/gartenverwaltung/io/JsonCropList.java

@@ -19,6 +19,11 @@ import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 
+/**
+ * Implements the {@link CropList} interface for reading and writing {@link Crop} objects
+ * from and to a local JSON file.
+ * The reads are cached to minimize file-io operations.
+ */
 public class JsonCropList implements CropList {
     private final URL dataSource;
 
@@ -40,7 +45,7 @@ public class JsonCropList implements CropList {
     }
 
     /**
-     * Default constructor
+     * Default constructor. Uses a file from the app resources.
      */
     public JsonCropList() {
         this.dataSource = getClass().getResource("user-crops.json");

src/main/java/ch/zhaw/gartenverwaltung/io/JsonPlantList.java

@@ -20,8 +20,8 @@ import java.util.Map;
 import java.util.Optional;
 
 /**
- * Implements the {@link PlantList} interface for loading {@link Plant} objects
+ * Implements the {@link PlantList} interface for reading {@link Plant} objects
- * from a JSON file.
+ * from a local JSON file.
  * The reads are cached to minimize file-io operations.
  */
 public class JsonPlantList implements PlantList {
@@ -44,9 +44,17 @@ public class JsonPlantList implements PlantList {
         imageModule.addDeserializer(Image.class, new PlantImageDeserializer());
     }
 
+    /**
+     * Default constructor. Uses a file from the app resources.
+     */
     public JsonPlantList() {
         this.dataSource = getClass().getResource("plantdb.json");
     }
+
+    /**
+     * Constructor to use a specified {@link URL} as a {@link #dataSource}
+     * @param dataSource A {@link URL} to the file to be used as a data source
+     */
     public JsonPlantList(URL dataSource) {
         this.dataSource = dataSource;
     }
@@ -67,7 +75,7 @@ public class JsonPlantList implements PlantList {
     }
 
     /**
-     * @see PlantList#getPlantById(long)
+     * @see PlantList#getPlantById(HardinessZone, long)
      */
     @Override
     public Optional<Plant> getPlantById(HardinessZone zone, long id) throws HardinessZoneNotSetException, IOException {

src/main/java/ch/zhaw/gartenverwaltung/io/JsonTaskList.java

@@ -20,8 +20,8 @@ import java.util.List;
 import java.util.Map;
 
 /**
- * Implements the {@link TaskList} interface for loading and writing {@link Task} objects
+ * Implements the {@link TaskList} interface for reading and writing {@link Task} objects
- * from and to a JSON file.
+ * from and to a local JSON file.
  * The reads are cached to minimize file-io operations.
  */
 public class JsonTaskList implements TaskList {
@@ -45,9 +45,17 @@ public class JsonTaskList implements TaskList {
         timeModule.addSerializer(LocalDate.class, dateSerializer);
     }
 
+    /**
+     * Default constructor. Uses a file from the app resources.
+     */
     public JsonTaskList() {
         this.dataSource = getClass().getResource("taskdb.json");
     }
+
+    /**
+     * Constructor to use a specified {@link URL} as a {@link #dataSource}
+     * @param dataSource A {@link URL} to the file to be used as a data source
+     */
     public JsonTaskList(URL dataSource) {
         this.dataSource = dataSource;
     }
@@ -88,7 +96,8 @@ public class JsonTaskList implements TaskList {
         if(taskMap.isEmpty()) {
             loadTaskListFromFile();
         }
-        taskMap.values().removeIf(task -> task.getCropId() == cropId);
+        taskMap.entrySet().removeIf(entry -> entry.getValue().getCropId() == cropId);
+        writeTaskListToFile();
         notifySubscribers();
     }
 

src/main/java/ch/zhaw/gartenverwaltung/io/PlantList.java

@@ -8,7 +8,7 @@ import java.util.List;
 import java.util.Optional;
 
 /**
- * A database of {@link Plant}s.
+ * A List of {@link Plant}s.
  * The interface specifies the minimal required operations.
  */
 public interface PlantList {

src/main/java/ch/zhaw/gartenverwaltung/io/TaskList.java

@@ -7,8 +7,8 @@ import java.time.LocalDate;
 import java.util.List;
 
 /**
- * A database of {@link Task}s.
+ * Represents a List of {@link Task}s.
- * The interface specifies the minimal required operations.
+ * The interface specifies the operations to add/update and remove entries.
  */
 public interface TaskList {
     /**

src/main/java/ch/zhaw/gartenverwaltung/json/GrowthPhaseTypeDeserializer.java

@@ -7,6 +7,9 @@ import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 
 import java.io.IOException;
 
+/**
+ * Used by the Jackson Library to deserialize a String to a {@link GrowthPhaseType}
+ */
 public class GrowthPhaseTypeDeserializer extends StdDeserializer<GrowthPhaseType> {
     public GrowthPhaseTypeDeserializer(Class<?> vc) {
         super(vc);

src/main/java/ch/zhaw/gartenverwaltung/json/HardinessZoneDeserializer.java

@@ -7,6 +7,9 @@ import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 
 import java.io.IOException;
 
+/**
+ * Used by the Jackson Library to deserialize a String to a {@link HardinessZone}
+ */
 public class HardinessZoneDeserializer extends StdDeserializer<HardinessZone> {
     public HardinessZoneDeserializer(Class<?> vc) {
         super(vc);

src/main/java/ch/zhaw/gartenverwaltung/json/PlantImageDeserializer.java

@@ -13,18 +13,17 @@ import java.io.InputStream;
 import java.net.URISyntaxException;
 import java.net.URL;
 
+/**
+ * Used by the Jackson Library to deserialize a String to a {@link Image}
+ */
 public class PlantImageDeserializer extends JsonDeserializer<Image> {
 
     @Override
     public Image deserialize(JsonParser parser, DeserializationContext context) throws IOException {
         Image result = null;
-        URL imageUrl = PlantList.class.getResource(String.format("images/%s", parser.getText()));
+        InputStream is = PlantList.class.getResourceAsStream(String.format("images/%s", parser.getText()));
-        if (imageUrl != null) {
+        if (is != null) {
-            try (InputStream is = new FileInputStream(new File(imageUrl.toURI()))) {
             result = new Image(is);
-            } catch (IllegalArgumentException | URISyntaxException e) {
-                throw new IOException(String.format("Cannot find Image \"%s\"\n", imageUrl.getFile()));
-            }
         }
         return result;
     }

src/main/java/ch/zhaw/gartenverwaltung/models/GardenSchedule.java

@@ -146,14 +146,18 @@ public class GardenSchedule {
             dayTaskList.add(new ArrayList<>());
             final int finalI = i;
             weekTasks.forEach(task -> {
+                if (task.getNextExecution() == null) {
+                    task.isDone();
+                } else {
                     LocalDate checkDate = task.getNextExecution();
+
                     do {
                         if (date.equals(checkDate) && !date.isAfter(task.getEndDate().orElse(LocalDate.MIN))) {
                             dayTaskList.get(finalI).add(task);
                         }
-                    if (task.getInterval().orElse(0) == 0) break;
                         checkDate = checkDate.plusDays(task.getInterval().orElse(0));
-                } while (task.getInterval().isPresent() && checkDate.isBefore(LocalDate.now().plusDays(listLength)));
+                    } while (!(task.getInterval().orElse(0) == 0) && checkDate.isBefore(LocalDate.now().plusDays(listLength)));
+                }
             });
         }
         return dayTaskList;
@@ -188,6 +192,6 @@ public class GardenSchedule {
      * @return a sorted coppy of the given Tasklist
      */
     private List<Task> getSortedTaskList(List<Task> taskList, Comparator<Task> comparator) {
-        return taskList.stream().sorted(comparator).collect(Collectors.toList());
+        return taskList.stream().filter(task -> task.getNextExecution() != null).sorted(comparator).collect(Collectors.toList());
     }
 }

src/main/java/ch/zhaw/gartenverwaltung/types/Plant.java

@@ -66,16 +66,16 @@ public record Plant(
     public int timeToHarvest(int group) {
         List<GrowthPhase> activeLifecycle = lifecycleForGroup(group);
         GrowthPhase sow = activeLifecycle.stream()
-                .filter(growthPhase -> !growthPhase.type().equals(GrowthPhaseType.SOW))
+                .filter(growthPhase -> growthPhase.type().equals(GrowthPhaseType.SOW))
                 .findFirst()
                 .orElseThrow();
         GrowthPhase harvest = activeLifecycle.stream()
-                .filter(growthPhase -> !growthPhase.type().equals(GrowthPhaseType.HARVEST))
+                .filter(growthPhase -> growthPhase.type().equals(GrowthPhaseType.HARVEST))
                 .findFirst()
                 .orElseThrow();
 
         int currentYear = LocalDate.now().getYear();
-        return (int) DAYS.between(harvest.startDate().atYear(currentYear), sow.startDate().atYear(currentYear));
+        return (int) DAYS.between(sow.startDate().atYear(currentYear),harvest.startDate().atYear(currentYear));
     }
 
     public int lifecycleGroupFromHarvestDate(LocalDate harvestDate) {

src/main/java/ch/zhaw/gartenverwaltung/types/Seasons.java

@@ -3,7 +3,7 @@ package ch.zhaw.gartenverwaltung.types;
 import java.time.MonthDay;
 
 public enum Seasons {
-    AllSEASONS("--01-01", "--12-31", "All Seasons"),
+    ALLSEASONS("--01-01", "--12-31", "All Seasons"),
     SPRING("--03-01", "--05-30", "Spring"),
     SUMMER("--06-01", "--08-30", "Summer"),
     AUTUMN("--09-01", "--11-30", "Autumn"),

src/main/java/ch/zhaw/gartenverwaltung/types/TaskTemplate.java

@@ -42,7 +42,7 @@ public class TaskTemplate {
     }
 
     public Task generateTask(LocalDate realStartDate, long cropId) {
-        LocalDate endDate = relativeEndDate != null ? realStartDate.plusDays(relativeEndDate) : realStartDate.plusDays(0);
+        LocalDate endDate = relativeEndDate != null ? realStartDate.plusDays(relativeEndDate) : realStartDate;
 
         if (interval == null) {
             this.interval = 0;

src/main/resources/ch/zhaw/gartenverwaltung/MainFXML.fxml

@@ -7,14 +7,14 @@
 
 <AnchorPane maxHeight="-Infinity" maxWidth="-Infinity" minHeight="-Infinity" minWidth="-Infinity" prefHeight="938.0" prefWidth="1110.0" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1" fx:controller="ch.zhaw.gartenverwaltung.MainFXMLController">
    <children>
-      <HBox maxWidth="35.0" minHeight="35.0" prefHeight="38.0" prefWidth="1110.0" AnchorPane.leftAnchor="0.0" AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="0.0">
+      <HBox fx:id="menubar" maxWidth="35.0" minHeight="40.0" prefHeight="38.0" prefWidth="1110.0" AnchorPane.leftAnchor="0.0" AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="0.0">
          <children>
-            <Button fx:id="home_button" mnemonicParsing="false" onAction="#goToHome" prefHeight="38.0" prefWidth="40.0" HBox.hgrow="NEVER" />
+            <Button fx:id="home_button" mnemonicParsing="false" onAction="#goToHome" prefHeight="38.0" prefWidth="38.0" HBox.hgrow="NEVER" />
             <Button fx:id="myGarden_button" layoutX="10.0" layoutY="10.0" mnemonicParsing="false" onAction="#goToMyPlants" prefHeight="38.0" prefWidth="121.0" text="My Garden" />
             <Button fx:id="mySchedule_button" layoutX="10.0" layoutY="10.0" mnemonicParsing="false" onAction="#goToMySchedule" prefHeight="38.0" prefWidth="121.0" text="My Schedule" />
             <Button fx:id="tutorial_button" layoutX="10.0" layoutY="10.0" mnemonicParsing="false" onAction="#showTutorial" prefHeight="38.0" prefWidth="121.0" text="Tutorial" />
-            <Pane maxWidth="1.7976931348623157E308" prefHeight="200.0" prefWidth="200.0" HBox.hgrow="ALWAYS" />
+            <Pane fx:id="menu_pane" maxWidth="1.7976931348623157E308" prefHeight="200.0" prefWidth="200.0" HBox.hgrow="ALWAYS" />
-            <Button fx:id="settings_button" maxHeight="1.7976931348623157E308" mnemonicParsing="false" onAction="#openSettings" prefHeight="38.0" prefWidth="40.0" HBox.hgrow="NEVER" />
+            <Button fx:id="settings_button" mnemonicParsing="false" onAction="#openSettings" prefHeight="38.0" prefWidth="38.0" HBox.hgrow="NEVER" />
          </children>
       </HBox>
       <AnchorPane fx:id="mainPane" prefHeight="200.0" prefWidth="200.0" AnchorPane.bottomAnchor="0.0" AnchorPane.leftAnchor="0.0" AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="35.0" />

src/main/resources/ch/zhaw/gartenverwaltung/bootstrap/styles.css

@@ -1,6 +1,25 @@
-.button{
+/*
-    -fx-text-fill: rgb(49, 89, 23);
+
-    -fx-border-color: rgb(49, 89, 23);
+#home_button, #myGarden_button,
-    -fx-border-radius: 5;
+#mySchedule_button, #settings_button,
-    -fx-padding: 3 6 6 6;
+#tutorial_button, #menu_pane {
+    -fx-text-fill: white;
+    -fx-background-color: rgb(0,128,0);
 }
+
+#menubar {
+    -fx-background-color: rgb(0,128,0);
+}
+
+#home_button:hover, #myGarden_button:hover,
+#mySchedule_button:hover, #settings_button:hover,
+#tutorial_button:hover,
+#home_button:focused, #myGarden_button:focused,
+#mySchedule_button:focused, #settings_button:focused,
+#tutorial_button:focused{
+    -fx-background-color: darkgreen;
+}
+
+.root, .split-pane {
+    -fx-background-color: linear-gradient(green 0%, lawngreen 33%, lightgreen 66%, #eee 100%);
+}./

src/test/java/ch/zhaw/gartenverwaltung/io/JsonCropListTest.java

@@ -30,6 +30,7 @@ public class JsonCropListTest {
      */
     private final URL dbDataSource = this.getClass().getResource("test-user-crops.json");
     private final URL testFile = this.getClass().getResource("template-user-crops.json");
+    private final URL corruptTestFile = this.getClass().getResource("corrupt-template-user-crops.json");
 
     @BeforeEach
     void connectToDb() throws URISyntaxException, IOException {
@@ -101,5 +102,13 @@ public class JsonCropListTest {
             throw new RuntimeException(e);
         }
     }
+
+    @Test
+    void detectCorruptJsonResource(){
+        JsonCropList tL = new JsonCropList(corruptTestFile);
+        Assertions.assertThrows(InvalidJsonException.class, () -> {
+            tL.getCrops();
+        });
+    }
 }
 

src/test/java/ch/zhaw/gartenverwaltung/io/JsonPlantListTest.java

@@ -15,6 +15,7 @@ import java.util.Optional;
 import java.util.stream.Collectors;
 
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public class JsonPlantListTest {
     private final URL testFile = this.getClass().getResource("test-plantdb.json");
@@ -62,6 +63,8 @@ public class JsonPlantListTest {
     void getPlantByIdAndZone() {
         Optional<Plant> testPlant;
         try {
+            assertThrows(HardinessZoneNotSetException.class, () -> testDatabase.getPlantById(null,1).get());
+
             testPlant = testDatabase.getPlantById(HardinessZone.ZONE_8A, 1);
         } catch (IOException | HardinessZoneNotSetException e) {
             throw new RuntimeException(e);
@@ -95,5 +98,16 @@ public class JsonPlantListTest {
 
     }
 
+    @Test
+    void testDefaultConstructor(){
+        JsonPlantList db = new JsonPlantList();
+        try {
+            assertNotNull(db.getPlantList(HardinessZone.ZONE_8A));
+        } catch (IOException | HardinessZoneNotSetException e) {
+            throw new RuntimeException(e);
+        }
+
+    }
+
 }
 

src/test/java/ch/zhaw/gartenverwaltung/io/JsonTaskListTest.java

@@ -2,6 +2,8 @@ package ch.zhaw.gartenverwaltung.io;
 
 import ch.zhaw.gartenverwaltung.types.Task;
 import org.junit.jupiter.api.*;
+import org.mockito.ArgumentMatchers;
+import org.mockito.Mockito;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
@@ -14,6 +16,8 @@ import java.time.format.DateTimeFormatter;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
 
 public class JsonTaskListTest {
 
@@ -47,17 +51,16 @@ public class JsonTaskListTest {
 
     }
 
-    @Disabled("disabled until adding works.")
     @Test
     @DisplayName("Add task.")
     void addTask() {
-        Task task = new Task("Testtask", "This is a test Task.", LocalDate.parse("01.05.2022", formatter), 1);
+        Task task = new Task("Testtask", "This is a test Task.", LocalDate.parse("2022-05-01", formatter), 1);
         try {
             testDatabase.saveTask(task);
             List<Task> taskList;
             try {
-                taskList = testDatabase.getTaskList(LocalDate.parse("30.04.2022", formatter),
+                taskList = testDatabase.getTaskList(LocalDate.parse("2022-04-30", formatter),
-                        LocalDate.parse("31.05.2022", formatter));
+                        LocalDate.parse("2022-05-31", formatter));
             } catch (IOException e) {
                 throw new RuntimeException(e);
             }
@@ -72,8 +75,7 @@ public class JsonTaskListTest {
     @Test
     @DisplayName("Remove task.")
     void removeTask() {
-        Task task = new Task("Dummy", "Dummy", LocalDate.parse("2022-05-31", formatter), 1)
+        Task task = new Task("Dummy", "Dummy", LocalDate.parse("2022-05-31", formatter), 1).withId(2);
-                .withId(2);
         try {
             testDatabase.removeTask(task);
             List<Task> taskList;
@@ -102,7 +104,7 @@ public class JsonTaskListTest {
 
     }
 
-    @Disabled("Disabled until removing works")
+
     @Test
     void removeTasksForCrop() {
         List<Task> taskList;
@@ -115,4 +117,27 @@ public class JsonTaskListTest {
 
         Assertions.assertEquals(0, taskList.size());
     }
+
+    @Test
+    void testDefaultConstructor(){
+        JsonTaskList db = new JsonTaskList();
+        try {
+            assertNotNull(db.getTaskForCrop(0));
+        } catch (IOException e) {
+            throw new RuntimeException(e);
+        }
+
+    }
+
+    @Test
+    void testSubscription() {
+        TaskList.TaskListObserver mockObs = Mockito.mock(TaskList.TaskListObserver.class);
+        testDatabase.subscribe(mockObs);
+        try {
+            testDatabase.removeTasksForCrop(0);
+        } catch (IOException e) {
+            throw new RuntimeException(e);
+        }
+        verify(mockObs, times(1)).onChange(ArgumentMatchers.anyList());
+    }
 }

src/test/java/ch/zhaw/gartenverwaltung/models/GardenScheduleTest.java

@@ -188,6 +188,7 @@ class GardenScheduleTest {
 
     @Test
     void planTasksForCrop() throws HardinessZoneNotSetException, PlantNotFoundException, IOException {
+        assertThrows(PlantNotFoundException.class,()-> model.planTasksForCrop(new Crop()));
         model.planTasksForCrop(new Crop(20, exampleStartDate).withId(30));
         verify(exampleTaskTemplateList.get(0), times(1)).generateTask(exampleStartDate, 30);
         verify(exampleTaskTemplateList.get(1), times(1)).generateTask(exampleStartDate, 30);

src/test/java/ch/zhaw/gartenverwaltung/types/PlantTest.java

@@ -0,0 +1,97 @@
+package ch.zhaw.gartenverwaltung.types;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import java.time.LocalDate;
+import java.time.MonthDay;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class PlantTest {
+
+    Plant testPlant;
+
+    @BeforeEach
+    void setUp() {
+        List<GrowthPhase> growthPhases = new ArrayList<>();
+        growthPhases.add(new GrowthPhase(MonthDay.of(2, 1), MonthDay.of(4, 4), 0, new WateringCycle(0, 0, null), GrowthPhaseType.SOW, HardinessZone.ZONE_8A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(4, 2), MonthDay.of(6, 5), 0, new WateringCycle(0, 0, null), GrowthPhaseType.PLANT, HardinessZone.ZONE_8A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(6, 3), MonthDay.of(8, 6), 0, new WateringCycle(0, 0, null), GrowthPhaseType.HARVEST, HardinessZone.ZONE_8A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(3, 1), MonthDay.of(5, 4), 1, new WateringCycle(0, 0, null), GrowthPhaseType.SOW, HardinessZone.ZONE_8A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(5, 2), MonthDay.of(7, 5), 1, new WateringCycle(0, 0, null), GrowthPhaseType.PLANT, HardinessZone.ZONE_8A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(7, 3), MonthDay.of(9, 6), 1, new WateringCycle(0, 0, null), GrowthPhaseType.HARVEST, HardinessZone.ZONE_8A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(4, 1), MonthDay.of(6, 4), 0, new WateringCycle(0, 0, null), GrowthPhaseType.SOW, HardinessZone.ZONE_1A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(6, 2), MonthDay.of(8, 5), 0, new WateringCycle(0, 0, null), GrowthPhaseType.PLANT, HardinessZone.ZONE_1A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(7, 2), MonthDay.of(9, 5), 0, new WateringCycle(0, 0, null), GrowthPhaseType.PLANT, HardinessZone.ZONE_1A, new ArrayList<>()));
+        growthPhases.add(new GrowthPhase(MonthDay.of(8, 3), MonthDay.of(10, 6), 0, new WateringCycle(0, 0, null), GrowthPhaseType.HARVEST, HardinessZone.ZONE_1A, new ArrayList<>()));
+
+        testPlant = new Plant(
+                20,
+                "summertime onion",
+                "Onion, (Allium cepa), herbaceous biennial plant in the amaryllis family (Amaryllidaceae) grown for its edible bulb. The onion is likely native to southwestern Asia but is now grown throughout the world, chiefly in the temperate zones. Onions are low in nutrients but are valued for their flavour and are used widely in cooking. They add flavour to such dishes as stews, roasts, soups, and salads and are also served as a cooked vegetable.",
+                null,
+                "15,30,2",
+                0,
+                "sandy to loamy, loose soil, free of stones",
+                new ArrayList<>(),
+                growthPhases);
+    }
+
+    @AfterEach
+    void tearDown() {
+    }
+
+    @Test
+    void inZone() {
+        assertEquals(7,testPlant.lifecycleForGroup(0).size());
+        testPlant.inZone(HardinessZone.ZONE_8A);
+        assertEquals(3,testPlant.lifecycleForGroup(0).size());
+        assertEquals(Arrays.asList(3,5,7),testPlant.lifecycleForGroup(1).stream().map(gp ->gp.startDate().getMonthValue()).toList() );
+        testPlant.inZone(HardinessZone.ZONE_1A);
+        assertEquals(0,testPlant.lifecycleForGroup(0).size());
+    }
+
+    @Test
+    void lifecycleForGroup() {
+        assertEquals(Arrays.asList(2,4,6,4,6,7,8),testPlant.lifecycleForGroup(0).stream().map(gp ->gp.startDate().getMonthValue()).toList() );
+        assertEquals(Arrays.asList(3,5,7),testPlant.lifecycleForGroup(1).stream().map(gp ->gp.startDate().getMonthValue()).toList() );
+
+    }
+
+    @Test
+    void sowDateFromHarvestDate() {
+        assertEquals(LocalDate.of(2022,8,1),
+                testPlant.sowDateFromHarvestDate(LocalDate.of(2022,12,1))
+        );
+    }
+
+    @Test
+    void timeToHarvest() {
+        testPlant.inZone(HardinessZone.ZONE_8A);
+        assertEquals(122,testPlant.timeToHarvest(0));
+    }
+
+    @Test
+    void lifecycleGroupFromHarvestDate() {
+        testPlant.inZone(HardinessZone.ZONE_8A);
+        assertEquals(0,testPlant.lifecycleGroupFromHarvestDate(LocalDate.of(2022,6,30)));
+        assertEquals(1,testPlant.lifecycleGroupFromHarvestDate(LocalDate.of(2022,8,30)));
+    }
+
+    @Test
+    void isDateInPhase() {
+        assertTrue(testPlant.isDateInPhase(LocalDate.of(2022,6,30),GrowthPhaseType.HARVEST));
+        assertTrue(testPlant.isDateInPhase(LocalDate.of(2022,8,30),GrowthPhaseType.HARVEST));
+        assertTrue(testPlant.isDateInPhase(LocalDate.of(2022,2,1),GrowthPhaseType.SOW));
+        assertTrue(testPlant.isDateInPhase(LocalDate.of(2022,4,2),GrowthPhaseType.PLANT));
+        assertFalse(testPlant.isDateInPhase(LocalDate.of(2022,6,30),GrowthPhaseType.SOW));
+
+
+    }
+}

src/test/java/ch/zhaw/gartenverwaltung/types/SeasonsTest.java

@@ -0,0 +1,38 @@
+package ch.zhaw.gartenverwaltung.types;
+
+import org.junit.jupiter.api.Test;
+
+import java.time.MonthDay;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class SeasonsTest {
+
+    @Test
+    void getStartDate() {
+        assertEquals(MonthDay.of(1,1), Seasons.ALLSEASONS.getStartDate());
+        assertEquals(MonthDay.of(3,1), Seasons.SPRING.getStartDate());
+        assertEquals(MonthDay.of(6,1), Seasons.SUMMER.getStartDate());
+        assertEquals(MonthDay.of(9,1), Seasons.AUTUMN.getStartDate());
+        assertEquals(MonthDay.of(12,1), Seasons.WINTER.getStartDate());
+    }
+
+    @Test
+    void getEndDate() {
+        assertEquals(MonthDay.of(12,31), Seasons.ALLSEASONS.getEndDate());
+        assertEquals(MonthDay.of(5,30), Seasons.SPRING.getEndDate());
+        assertEquals(MonthDay.of(8,30), Seasons.SUMMER.getEndDate());
+        assertEquals(MonthDay.of(11,30), Seasons.AUTUMN.getEndDate());
+        assertEquals(MonthDay.of(2,28), Seasons.WINTER.getEndDate());
+    }
+
+    @Test
+    void getName() {
+        assertEquals("All Seasons", Seasons.ALLSEASONS.getName());
+        assertEquals("Spring", Seasons.SPRING.getName());
+        assertEquals("Summer", Seasons.SUMMER.getName());
+        assertEquals("Autumn", Seasons.AUTUMN.getName());
+        assertEquals("Winter", Seasons.WINTER.getName());
+
+    }
+}

src/test/resources/ch/zhaw/gartenverwaltung/io/corrupt-template-user-crops.json

@@ -0,0 +1,7 @@
+[
+  {
+    "plantId": 1,
+    "startDate": "2023-02-25",
+    "area": 0.5
+  }
+]